-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Long column names are cut off in the "Manage Columns" menu #2353
base: alpha
Are you sure you want to change the base?
Conversation
Sync with original repo
Thanks for opening this pull request!
|
This branch has been deployed using Uffizzi. Preview URL: View deployment details here: This is an automated comment. To turn off commenting, visit uffizzi.com. |
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Magdaraa, thanks for the PR and apologies for the long wait for review. It looks good, just a few observations:
- There is still space at the right side of the menu for the tab to expand, but it doesn't. If that is too difficult to enable, then no worries.
- When a name is truncated
abcdef...
, it would be to truncate the middle of the string, likeabc...xyz
. This allows to distinguish two strings that are both truncated and are only different in the end.
Whatever you could improve of the above would be fantastic, otherwise we can also merge as is, as it's already an improvement from before. And the lint check fails, should be easy to fix.
New Pull Request Checklist
Issue Description
The tap that opens when clicking the "Manage Columns" menu has a fixed size and therefore cuts off long column names
Closes: #1892
Approach
Column name isn't cut off, tab is adapt to the width
I did it with help from @404-html