Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Long column names are cut off in the "Manage Columns" menu #2353

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from

Conversation

Magdaraa
Copy link
Contributor

@Magdaraa Magdaraa commented Dec 26, 2022

New Pull Request Checklist

Issue Description

The tap that opens when clicking the "Manage Columns" menu has a fixed size and therefore cuts off long column names

Closes: #1892

Approach

Column name isn't cut off, tab is adapt to the width

I did it with help from @404-html

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 26, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the title Fix for "Manage Columns" tab cuts off long column names fix: Column names cut off in the "Manage Columns" menu Dec 27, 2022
@mtrezza mtrezza changed the title fix: Column names cut off in the "Manage Columns" menu fix: Long field names are cut off in the "Manage Columns" menu Dec 27, 2022
@mtrezza mtrezza changed the title fix: Long field names are cut off in the "Manage Columns" menu fix: Long column names are cut off in the "Manage Columns" menu Dec 27, 2022
@mtrezza mtrezza requested a review from a team December 28, 2022 01:07
@mtrezza mtrezza closed this Jan 27, 2023
@mtrezza mtrezza reopened this Jan 27, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jan 27, 2023

This branch has been deployed using Uffizzi.

Preview URL:
https://pr-2353-deployment-12538-parse-dashboard.app.uffizzi.com

View deployment details here:
https://https://app.uffizzi.com/projects/5259/deployments

This is an automated comment. To turn off commenting, visit uffizzi.com.

@mtrezza mtrezza closed this Mar 23, 2024
@mtrezza mtrezza reopened this Mar 23, 2024
Copy link

uffizzi-cloud bot commented Mar 23, 2024

Uffizzi Ephemeral Environment deployment-48847

⌚ Updated Mar 23, 2024, 15:22 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2353

📄 View Application Logs etc.

What is Uffizzi? Learn more

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Magdaraa, thanks for the PR and apologies for the long wait for review. It looks good, just a few observations:

image
  1. There is still space at the right side of the menu for the tab to expand, but it doesn't. If that is too difficult to enable, then no worries.
  2. When a name is truncated abcdef... , it would be to truncate the middle of the string, like abc...xyz. This allows to distinguish two strings that are both truncated and are only different in the end.

Whatever you could improve of the above would be fantastic, otherwise we can also merge as is, as it's already an improvement from before. And the lint check fails, should be easy to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Manage Columns" tab cuts off long column names
2 participants