-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Keyboard accessibility is broken in filter dialog in data browser #2482
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! |
Uffizzi Ephemeral Environment
|
I have implemented the basic selection functionality, such as moving up, down, and using the
source: #2478 |
Hah, who would have thought! Thanks for looking into this. |
@AshishBarvaliya Could you resolve the conflicts so we can get this ready for merge? |
@AshishBarvaliya Do you think we could get this merged? It seems to be ready, just the conflicts. |
Issue Description
Closes: #2469
Approach
The keyboard accessibility code was present, but unfortunately, it wasn't functioning due to a bug.