Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade to mime 4.0.4 #9363

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

Moumouls
Copy link
Member

Pull Request

Issue

Closes: #9248

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

dependabot bot and others added 3 commits July 26, 2024 15:43
Bumps [mime](https://github.com/broofa/mime) from 3.0.0 to 4.0.4.
- [Changelog](https://github.com/broofa/mime/blob/main/CHANGELOG.md)
- [Commits](broofa/mime@v3.0.0...v4.0.4)

---
updated-dependencies:
- dependency-name: mime
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: upgrade to mime 4 feat: Upgrade to mime 4 Oct 23, 2024
Copy link

Thanks for opening this pull request!

# Conflicts:
#	package-lock.json
#	package.json
#	spec/FilesController.spec.js
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (412e724) to head (b8dcfe3).
Report is 1 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9363   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         186      186           
  Lines       14812    14812           
=======================================
  Hits        13847    13847           
  Misses        965      965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/FilesController.spec.js Outdated Show resolved Hide resolved
src/Routers/FilesRouter.js Show resolved Hide resolved
@Moumouls
Copy link
Member Author

@mtrezza are you aware of a possible flaky on Mongo 8 CI, since this PR don't touch to mongo it self and there is some failure ?

@mtrezza
Copy link
Member

mtrezza commented Oct 23, 2024

@mtrezza are you aware of a possible flaky on Mongo 8 CI, since this PR don't touch to mongo it self and there is some failure ?

We can always re-run the CI to see; is this ready for merge, once the CI passes?

@Moumouls Moumouls requested a review from a team October 23, 2024 16:57
@Moumouls
Copy link
Member Author

yes @mtrezza ready for merge

@mtrezza mtrezza changed the title feat: Upgrade to mime 4 refactor: Upgrade to mime 4 Oct 23, 2024
@mtrezza mtrezza changed the title refactor: Upgrade to mime 4 refactor: Upgrade to mime 4.0.4 Oct 23, 2024
@mtrezza mtrezza merged commit 3a9442a into parse-community:alpha Oct 23, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants