Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Mongodb-runner usage and default version to 6.0.2 #9383

Open
wants to merge 4 commits into
base: alpha
Choose a base branch
from

Conversation

Moumouls
Copy link
Member

Pull Request

Issue

Closes: none

Approach

Mongodb runner use a global folder by default, it could conflict with old failed instances or other running instances non related to parse-server development.

Now using a dedicated folder during contributing phase, so it's easier to clean the folder in case of unexpected failure.
Also updating default version to 6.0.2, because 6.X is compatible with Windows/Mac Intel/Mac ARM.
5.X don't start on Mac ARM so it always need a manual adjustment to contribute to parse.
5.X is now quite old also.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: mongodb-runner usage and default version to 6.0.2 fix: Mongodb-runner usage and default version to 6.0.2 Oct 26, 2024
Copy link

parse-github-assistant bot commented Oct 26, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@Moumouls Moumouls requested a review from a team October 26, 2024 07:41
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (c8bc74a) to head (1dffc2f).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9383   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         186      186           
  Lines       14810    14810           
=======================================
  Hits        13846    13846           
  Misses        964      964           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title fix: Mongodb-runner usage and default version to 6.0.2 ci: Mongodb-runner usage and default version to 6.0.2 Oct 29, 2024
@mtrezza
Copy link
Member

mtrezza commented Oct 29, 2024

This PR should fix the issue of the mongodb runner not terminating all running instances?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to run the command npx mongodb-runner stop --all --runnerDir ./_mongodb_runner on linux and get:

[Error: ENOENT: no such file or directory, opendir './_mongodb_runner'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'opendir',
  path: './_mongodb_runner'
}

Node.js v18.18.2

Which is correct, the dir doesn't exist. I suppose something is missing in this PR? Doesn't starting the runner also require to specify the output dir for the runners?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants