Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Column list scroll issue & Row actions btn fix #409

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: Column list scroll issue & Row actions btn fix #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d81ca
fix: COlumn list scroll issue & Row actions btn fix
praveen5959 Jan 7, 2025
4e9f81e
fix: Row action btn visibility issue
praveen5959 Jan 7, 2025
cd3aabb
fix: Sidebar overlay when empty data
praveen5959 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/pages/Stream/Views/Explore/LogsViewConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ const ColumnsList = (props: { isLoading: boolean }) => {
onChangeHandler={onSearchHandler}
disabled={_.isEmpty(headers)}
/>
<Stack style={{ height: '100%' }} gap={0}>
<Stack style={{ flex: 1, overflowY: 'auto' }} gap={0}>
<Group
gap={8}
style={{ display: 'flex', justifyContent: 'flex-start', padding: '0 1rem', marginBottom: '0.3rem' }}>
Expand All @@ -272,7 +272,7 @@ const ColumnsList = (props: { isLoading: boolean }) => {
Clear All
</Text>
</Group>
<ScrollArea scrollbars="y">
<ScrollArea style={{ flex: 1 }}>
<DragDropContext onDragEnd={onDropEnd}>
<Droppable droppableId="columns">
{(provided) => (
Expand Down Expand Up @@ -323,10 +323,13 @@ const LogsViewConfig = (props: { schemaLoading: boolean; logsLoading: boolean; i
ref={divRef}
style={{
borderRight: '1px solid var(--mantine-color-gray-2)',
display: sideBarOpen ? 'none' : 'block',
width: sideBarOpen ? 0 : LOGS_CONFIG_SIDEBAR_WIDTH,
transition: 'width 0.5s',
}}>
<Stack style={{ width: LOGS_CONFIG_SIDEBAR_WIDTH, height: height - 30 }} className={classes.container}>
<Stack
style={{ width: LOGS_CONFIG_SIDEBAR_WIDTH, height: height - 30, overflowY: 'hidden', flex: 1 }}
className={classes.container}>
<Header />
{configViewType === 'schema' ? (
<SchemaList isLoading={props.schemaLoading || props.infoLoading} />
Expand Down
4 changes: 1 addition & 3 deletions src/pages/Stream/Views/Explore/StaticLogTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,7 @@ const makeHeaderOpts = (
style={{
display: isFirstSelectedRow && isFirstColumn ? 'flex' : '',
}}>
{isSecureHTTPContext
? sanitizedValue && <IconDotsVertical stroke={1.2} size={'0.8rem'} color="#545beb" />
: null}
{isSecureHTTPContext ? <IconDotsVertical stroke={1.2} size={'0.8rem'} color="#545beb" /> : null}
</div>
{sanitizedValue}
<div className={tableStyles.copyIconContainer}>
Expand Down
Loading