Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improvements to listing code for readability and less copy #1025

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 6, 2024

Fixes #XXXX.

These changes don't impact functionality, but they do have performance benefits in the form of lowering memory utilization through the removal of a large number of clones in places where they are not required, which even in the case of Arc does involve a cost. Plus, parts of the code have been reorganized to be functional in nature and hence not require frequent iteration over the same members.

As a bonus, comments explaining working have also been included

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh changed the title refactor: improvements to code for readability and less copy refactor: improvements to listing code for readability and less copy Dec 6, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12293704269

Details

  • 144 of 210 (68.57%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 10.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/arrow/flight.rs 0 1 0.0%
src/query/stream_schema_provider.rs 144 164 87.8%
src/query/listing_table_builder.rs 0 45 0.0%
Files with Coverage Reduction New Missed Lines %
src/query/stream_schema_provider.rs 1 24.55%
src/query/listing_table_builder.rs 4 0.0%
Totals Coverage Status
Change from base Build 12282572787: 0.7%
Covered Lines: 2034
Relevant Lines: 19142

💛 - Coveralls

@nitisht nitisht merged commit 386a662 into parseablehq:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants