Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DEPRECATE caching #1035

Merged
merged 1 commit into from
Dec 17, 2024
Merged

feat: DEPRECATE caching #1035

merged 1 commit into from
Dec 17, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 16, 2024

Fixes #XXXX.

Description

  • Removes all code that manages caching, be it query cache or local cache for quick query.
  • Responds to cache management API calls with 410 GONE HTTP response.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12348638420

Details

  • 0 of 20 (0.0%) changed or added relevant lines in 7 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.5%) to 10.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/object_storage.rs 0 1 0.0%
src/cli.rs 0 2 0.0%
src/query/stream_schema_provider.rs 0 2 0.0%
src/handlers/http/mod.rs 0 3 0.0%
src/handlers/http/modal/ingest_server.rs 0 4 0.0%
src/handlers/http/modal/query_server.rs 0 4 0.0%
src/handlers/http/modal/server.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
src/handlers/http/query.rs 1 0.0%
src/rbac/role.rs 1 0.0%
src/banner.rs 1 0.0%
src/handlers/http/modal/ingest_server.rs 1 0.0%
src/handlers/airplane.rs 2 0.0%
Totals Coverage Status
Change from base Build 12338907206: 0.5%
Covered Lines: 1887
Relevant Lines: 18039

💛 - Coveralls

Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitisht nitisht merged commit 5ce9d2b into parseablehq:main Dec 17, 2024
6 checks passed
@de-sh de-sh deleted the remove-cache branch December 17, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants