Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: convert all number data types to float" #1038

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented Dec 18, 2024

Reverts #1027

@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12408331795

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 31 of 32 (96.88%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 11.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/object_storage.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/storage/object_storage.rs 1 0.0%
src/metadata.rs 1 1.32%
src/catalog/column.rs 2 0.0%
Totals Coverage Status
Change from base Build 12371831926: -0.05%
Covered Lines: 2096
Relevant Lines: 18167

💛 - Coveralls

@nitisht
Copy link
Member Author

nitisht commented Dec 19, 2024

Merging because locally quest seems to pass

@nitisht nitisht merged commit 702dbc8 into main Dec 19, 2024
3 of 6 checks passed
@nitisht nitisht deleted the revert-1027-data-type-float branch December 19, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants