Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: subscribe to span creation events, log important ingestion and sync steps #1039

Merged
merged 3 commits into from
Dec 20, 2024
Merged

tracing: subscribe to span creation events, log important ingestion and sync steps #1039

merged 3 commits into from
Dec 20, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 18, 2024

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12425542724

Details

  • 0 of 29 (0.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 11.721%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/event/writer/mod.rs 0 1 0.0%
src/storage/staging.rs 0 1 0.0%
src/event/mod.rs 0 2 0.0%
src/handlers/http/modal/utils/ingest_utils.rs 0 2 0.0%
src/handlers/http/ingest.rs 0 4 0.0%
src/storage/object_storage.rs 0 19 0.0%
Totals Coverage Status
Change from base Build 12411844504: 0.2%
Covered Lines: 2096
Relevant Lines: 17883
💛 - Coveralls

@de-sh de-sh changed the title tracing: instrument functions on ingestion control-flow path and subscribe to span creation events tracing: subscribe to span creation events, log important ingestion and sync steps Dec 18, 2024
@de-sh de-sh marked this pull request as ready for review December 18, 2024 20:10
@de-sh de-sh changed the base branch from main to v1.6.3-trace December 20, 2024 07:45
de-sh added 2 commits December 20, 2024 13:17
@de-sh
refactor: log ~> tracing (parseablehq#1013)
445acd7 
Using tracing will allow us to capture span related info in addition to the event based context that we already capture

---------

Signed-off-by: Devdutt Shenoi <[email protected]>
@de-sh
note span creation and deletion
93949fd
@de-sh
Copy link
Contributor Author

de-sh commented Dec 20, 2024

Clippy is breaking because of code not affected by me in any way

@nitisht nitisht merged commit 1614cb7 into parseablehq:v1.6.3-trace Dec 20, 2024
7 of 8 checks passed
@de-sh de-sh deleted the traces branch December 20, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@de-sh @coveralls @nitisht