Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incompatibility from merge #1046

Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: incompatibility from merge #1046

merged 1 commit into from
Dec 21, 2024

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 20, 2024

Fixes type incompatibility that stems from merging #1021 after #981

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh requested a review from nitisht December 20, 2024 17:55
@nitisht nitisht merged commit 503eaa0 into parseablehq:main Dec 21, 2024
6 checks passed
@de-sh de-sh deleted the fix-merge branch December 21, 2024 03:20
parmesant pushed a commit to parmesant/parseable that referenced this pull request Dec 24, 2024
@de-sh @parmesant
fix: incompatibility from merge (parseablehq#1046)
f625975 
Fixes type incompatibility that stems from merging parseablehq#1021 after parseablehq#981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@de-sh @nitisht