Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow updating custom partition and time limit together #1054

Closed
wants to merge 2 commits into from

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Dec 25, 2024

Fixes #XXXX.

Description

Currently custom partition name and time-limit can't be set together in one API call, this PR changes that.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Dec 25, 2024

Pull Request Test Coverage Report for Build 12494004515

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 11.489%

Totals Coverage Status
Change from base Build 12492981664: 0.0%
Covered Lines: 2092
Relevant Lines: 18208

💛 - Coveralls

@de-sh de-sh changed the title fix: update stream API should allow updating custom partition and time limit together fix: allow updating custom partition and time limit together Dec 26, 2024
@de-sh de-sh requested a review from nitisht December 26, 2024 11:24
@de-sh de-sh closed this Dec 26, 2024
@de-sh de-sh deleted the fix-update-stream branch December 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants