refactor: single reqwest::Client for HTTP
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hippalus
reviewed
Jan 6, 2025
| @@ -73,6 +73,8 @@ relative-path = { version = "1.7", features = ["serde"] } | |||
| reqwest = { version = "0.11.27", default-features = false, features = [ | |||
There was a problem hiding this comment.
would be nice to have the latest version 0.12.x if there is no blocker issue.
There was a problem hiding this comment.
We will take this up in #1075
Pull Request Test Coverage Report for Build 12651787773Details
💛 - Coveralls |
|
@de-sh can you resolve the conflicts pls |
parmesant
pushed a commit
to parmesant/parseable
that referenced
this pull request
Jan 13, 2025
Co-authored-by: Nikhil Sinha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Use a single HTTP client to perform all normal outgoing HTTP requests from the parseable server.
Connection timeouts in 3s during setup, 10s per request and every 90s when not used/idling. Max 32 idle connections are allowed per host. gzip/brotli compression is enabled and can be used based on server(to which parseable connects) preference, rustls is used to perform TLS encryption (instead of native-tls) and only HTTP/1.1 connections are allowed (no HTTP/2)
This is different from the default client which has no timeouts, default pooling, no compression, and would support multiple TLS backends and HTTP versions.
This PR has: