Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Redesign #1101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parmesant
Copy link
Contributor

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@parmesant parmesant force-pushed the alerts-redesign-branch branch from 22090c2 to 61be3e6 Compare January 14, 2025 04:24
@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12761088257

Details

  • 0 of 1009 (0.0%) changed or added relevant lines in 11 files are covered.
  • 11 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-1.3%) to 11.087%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/localfs.rs 0 2 0.0%
src/rbac/role.rs 0 3 0.0%
src/query/mod.rs 0 7 0.0%
src/handlers/http/modal/query_server.rs 0 10 0.0%
src/storage/object_storage.rs 0 12 0.0%
src/handlers/http/modal/server.rs 0 35 0.0%
src/sync.rs 0 46 0.0%
src/alerts/target.rs 0 77 0.0%
src/handlers/http/alerts.rs 0 103 0.0%
src/alerts/alerts_utils.rs 0 277 0.0%
Files with Coverage Reduction New Missed Lines %
src/alerts/mod.rs 1 0.0%
src/metadata.rs 1 1.52%
src/event/mod.rs 1 0.0%
src/storage/object_storage.rs 2 0.0%
src/rbac/role.rs 2 0.0%
src/alerts/target.rs 4 0.0%
Totals Coverage Status
Change from base Build 12753189913: -1.3%
Covered Lines: 2163
Relevant Lines: 19509

💛 - Coveralls

@parmesant parmesant force-pushed the alerts-redesign-branch branch 4 times, most recently from 3e6dd6a to 38cd6d8 Compare January 17, 2025 16:18
@parmesant parmesant force-pushed the alerts-redesign-branch branch from 38cd6d8 to b484380 Compare January 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants