This repository has been archived by the owner on Mar 25, 2022. It is now read-only.
Add TCP Healthcheck Listener To STUN Service #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: Based on some awesome feedback from the team, I have split the health-check functionality into a side-car service which tests STUN protocol health over localhost. I have also updated the Dockerfile, and added a bootstrap script to launch both of the services.
The health-check service is HTTP based, it responds with HTTP status code 200 if the STUN service is healthy, and it responds with HTTP status code 503 if the STUN service is unhealthy.
Reference: https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/elb-healthchecks.html#health-check-configuration
The intent of this PR is to add a simple TCP listener to the STUN service that is suitable to handle AWS TCP health checks. This service is optional, and defaults to disabled.