Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiwallet support #20

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

multiwallet support #20

wants to merge 63 commits into from

Conversation

xludx
Copy link
Member

@xludx xludx commented Oct 21, 2019

No description provided.

@kewde
Copy link
Collaborator

kewde commented Nov 22, 2019 •
edited
Loading

Isn't it easier to specify the wallet in the Rpc service once rather than having to pass it on every command?

const service = new OmpService();
service.inject(rpc, "wallet");
service.using("wallet").bid(...);

xludx and others added 30 commits April 9, 2020 18:00
@xludx
v0.1.129
fe71241
@xludx
uppercase EscrowReleaseType enum values
83e32f2
@xludx
v0.1.130
bcd6a57
@xludx
Merge pull request #2 from zaSmilingIdiot/update/MPActionEnumChange
38888a5 
Changes the MPAction enum values
@xludx
v0.1.131
3f3d5ba
@xludx
removed SELLER from HashableItemField
3a03e97
@xludx
hasher logging
d15966a
@xludx
FV_MPM fix, compare the string enum values instead of keys
7c7fcb4
@xludx
added isStringAndEnumValue
6aef85a
@xludx
fixed the obvious problems with the tests after the change to listing…
648f05a 
… model (seller)
@xludx
0.1.135
44db37d
@xludx
.137, RpcBalances rpc interface, some test changes
d425353
@xludx
cleanup and a pretty stupid bid fix
933a279
@xludx
0.1.138
67f31c6
@xludx
EscrowReleaseType and OutputTypes to lowercase, since particld seems …
bf76d56 
…to care and bitch about Unknown output types
@xludx
0.1.139
e5705c5
@xludx
protocoldsn, content validation changes, 0.1.141
cd4258e
@xludx
hashable validation fix
5a70851
@xludx
fixed hashable, added tests, publish 0.1.143
d52de78
@xludx
0.1.148
1a00ce5
@xludx
remove hasher logs
83ed004
@xludx
0.1.150
609d08b
@xludx
bit of cleanup
27f9ffd
@zaSmilingIdiot
Allow for an optional address to be provided to createPrevoutFrom(), …
29dea85 
…and (NB\!\!) catches any error thrown from the sendTypeTo call as well.
@zaSmilingIdiot
Merge pull request #1 from zaSmilingIdiot/update/createPrevoutFrom
9fab7ea 
Allow for an optional address to be provided to createPrevoutFrom()
@xludx
Merge pull request #3 from zaSmilingIdiot/update/createPrevoutFrom
5172828 
Allow for an optional address to be provided to createPrevoutFrom()
@xludx
bump version
1738b8e
@xludx
bump version
a8a7d53
@zaSmilingIdiot
Re-throw the error when the call to sendTypeTo() errors (in createPre…
95cfc15 
…voutFrom()) so as to let the caller handle the error they threw when implementing sendTypeTo().
@xludx
Merge pull request #4 from zaSmilingIdiot/fix/bidAccept
452547f 
Fix error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xludx @kewde @zaSmilingIdiot