Fixes null comparisons and coercions of null collections #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnedquinn
force-pushed
the
v1-conformance-null-equality
branch
from
41bffc2 to
17f59e2
Compare
alancai98
approved these changes
Jul 16, 2024
| @@ -595,14 +595,13 @@ internal class PlanTyperTestsPorted { | |||
| catalog = "pql", | |||
| expected = StaticType.BOOL, | |||
| ), | |||
| ErrorTestCase( | |||
| // TODO: For some reason, the conformance tests say that this results in TRUE. Regardless, we know it returns | |||
There was a problem hiding this comment.
Could we cut an issue to partiql-tests for this? Or just fix the problematic conformance tests?
There was a problem hiding this comment.
| } | ||
| } | ||
|
|
||
| @OptIn(PartiQLValueExperimental::class, FnExperimental::class) |
There was a problem hiding this comment.
nice that we can get rid of all of these other eq Fns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Other Information
Updated Unreleased Section in CHANGELOG: NO
Any backward-incompatible changes? NO
Any new external dependencies? NO
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.