Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites PLUS and BITWISE_AND implementations using new modeling #1647

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Rewrites PLUS and BITWISE_AND implementations using new modeling #1647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b9d527
Rewrites PLUS and BITWISE_AND implementations using new modeling
johnedquinn Nov 18, 2024
177d913
Rewrites MINUS operator
johnedquinn Nov 14, 2024
302dac6
Extracts plus tests from the eval tests
johnedquinn Nov 18, 2024
c9971a7
Renames internal parameter names for the ArithmeticDiadicOperator
johnedquinn Nov 18, 2024
de7d36b
Updates the EQ function to simplify dynamic dispatch
johnedquinn Nov 18, 2024
4c9bc85
Adds an internal TypePrecedence object in SPI
johnedquinn Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rex/ExprCallDynamic.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,10 @@ internal class ExprCallDynamic(
exactMatches = currentExactMatches
}
}
return if (currentMatch == null) null else Candidate(functions[currentMatch!!].getInstance(args.toTypedArray()))
return if (currentMatch == null) null else {
val instance = functions[currentMatch!!].getInstance(args.toTypedArray()) ?: return null
Candidate(instance)
}
}

/**
Expand Down
8 changes: 8 additions & 0 deletions partiql-eval/src/test/kotlin/org/partiql/eval/PTestCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package org.partiql.eval

interface PTestCase : Runnable {
/**
* Executes the test case
*/
override fun run()
}
Loading
Loading