chore: Release v0.6.0 (#439) #111
benchmark.yml
on: push
Performance regression check
14m 50s
Annotations
1 error and 7 warnings
Performance regression check
# :warning: **Performance Alert** :warning:
Possible performance regression was detected for benchmark **'PartiQL (rust) Benchmark'**.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold `1.50`.
| Benchmark suite | Current: 6ef3177e3be2fb172c2702da3d5b93c946d2bb0e | Previous: 57ce9b80172923173a09d4c3e10565f7ebf796fd | Ratio |
|-|-|-|-|
| `plan-1` | `96812` ns/iter (`± 4347`) | `64531` ns/iter (`± 238`) | `1.50` |
This comment was automatically generated by [workflow](https://github.com/partiql/partiql-lang-rust/actions?query=workflow%3ABenchmark) using [github-action-benchmark](https://github.com/marketplace/actions/continuous-benchmark).
CC: @alancai98 @alancai98 @partiql
Comment was generated at https://github.com/partiql/partiql-lang-rust/commit/6ef3177e3be2fb172c2702da3d5b93c946d2bb0e#commitcomment-131495713
|
usage of `Iterator::fold` on a type that implements `Try`:
partiql-eval/src/eval/expr/path.rs#L132
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:132:18
|
132 | .fold(Some(owned), |v, path| {
| __________________^
133 | | v.and_then(|v| path.take_val(v, bindings, ctx))
134 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(owned, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
partiql-eval/src/eval/expr/path.rs#L125
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:125:18
|
125 | .fold(Some(borrowed), |v, path| {
| __________________^
126 | | v.and_then(|v| path.get_val(v, bindings, ctx))
127 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(borrowed, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
redundant pattern matching, consider using `is_some()`:
/home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-901404394be81442/out/partiql.rs#L47881
warning: redundant pattern matching, consider using `is_some()`
--> /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-901404394be81442/out/partiql.rs:47881:25
|
47881 | let recursive = matches!(rec, Some(_));
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rec.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|
Performance regression check
Performance alert! Previous value was 64531 and current value is 96812. It is 1.5002401946351367x worse than previous exceeding a ratio threshold 1.5
|
usage of `Iterator::fold` on a type that implements `Try`:
partiql-eval/src/eval/expr/path.rs#L132
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:132:18
|
132 | .fold(Some(owned), |v, path| {
| __________________^
133 | | v.and_then(|v| path.take_val(v, bindings, ctx))
134 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(owned, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
usage of `Iterator::fold` on a type that implements `Try`:
partiql-eval/src/eval/expr/path.rs#L125
warning: usage of `Iterator::fold` on a type that implements `Try`
--> partiql-eval/src/eval/expr/path.rs:125:18
|
125 | .fold(Some(borrowed), |v, path| {
| __________________^
126 | | v.and_then(|v| path.get_val(v, bindings, ctx))
127 | | })
| |__________________^ help: use `try_fold` instead: `try_fold(borrowed, |v, path| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
redundant pattern matching, consider using `is_some()`:
/home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-901404394be81442/out/partiql.rs#L47881
warning: redundant pattern matching, consider using `is_some()`
--> /home/runner/work/partiql-lang-rust/partiql-lang-rust/target/debug/build/partiql-parser-901404394be81442/out/partiql.rs:47881:25
|
47881 | let recursive = matches!(rec, Some(_));
| ^^^^^^^^^^^^^^^^^^^^^^ help: try: `rec.is_some()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
= note: `#[warn(clippy::redundant_pattern_matching)]` on by default
|