Add SQL aggregates ANY, SOME, EVERY and their COLL_ versions #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 81.70% 81.74% +0.04%
==========================================
Files 62 62
Lines 15235 15426 +191
Branches 15235 15426 +191
==========================================
+ Hits 12447 12610 +163
- Misses 2285 2303 +18
- Partials 503 513 +10
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5455 Number failing in both: 729 Number passing in Base (191b10e) but now fail: 0 Number failing in Base (191b10e) but now pass: 132 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
alancai98
force-pushed
the
add-any-some-every
branch
from
2e5cc1c
to
237826e
Compare
alancai98
force-pushed
the
add-any-some-every
branch
from
237826e
to
9d99994
Compare
|
Marking PR as draft. Will rebase on #413 once that PR is merged in to account for evaluation function binding changes. |
alancai98
force-pushed
the
add-any-some-every
branch
from
9d99994
to
9c84d51
Compare
alancai98
force-pushed
the
add-any-some-every
branch
from
9c84d51
to
aa98fd9
Compare
|
Test regression is partially due to a test misclassification that is corrected in: partiql/partiql-tests#107. Basically, the test ( Once that conformance test PR is merged in and I update this PR's partiql-tests submodule, the tests should pass. |
alancai98
commented
Aug 4, 2023
Comment on lines
+711
to
+716
| if select.having.is_some() && select.group_by.is_none() { | ||
| self.errors.push(AstTransformError::HavingWithoutGroupBy); | ||
| Traverse::Stop | ||
| } else { | ||
| Traverse::Continue | ||
| } |
There was a problem hiding this comment.
Some context for why this change is in this PR provided in this comment: #360 (comment)
alancai98
force-pushed
the
add-any-some-every
branch
2 times, most recently
from
7b818ad
to
751b5ce
Compare
alancai98
force-pushed
the
add-any-some-every
branch
from
98a4f9f
to
d4bb846
Compare
am357
approved these changes
Aug 8, 2023
jpschorr
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the SQL aggregate functions
ANY,SOME, andEVERYalong with theirCOLL_versions (i.e.COLL_ANY,COLL_SOME,COLL_EVERY).This PR also
NULLorMISSING.COLL_*functions #419 with some fixes to the strict mode type checking behavior of theCOLL_functions.HAVINGwithoutGROUP BYBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.