-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list/bag/tuple deep equality #421
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 82.05% 82.14% +0.09%
==========================================
Files 62 62
Lines 15706 15763 +57
Branches 15706 15763 +57
==========================================
+ Hits 12888 12949 +61
+ Misses 2299 2295 -4
Partials 519 519
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5649 Number failing in both: 678 Number passing in Base (d93dfe7) but now fail: 0 Number failing in Base (d93dfe7) but now pass: 16 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
f4a0fdd
to
3d312de
Compare
bf88a0e
to
498afb7
Compare
498afb7
to
8a191cf
Compare
8a191cf
to
d63cf7f
Compare
Closes #420.
Previously, the
NullableEq
operator (i.e.=
) wasn't performing deep equality on values within lists, bags, and tuples. PR adds the equivalent of theeqg
function specified in section 7.1.1 which definesNULL
s andMISSING
s as equal.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.