-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Value iterators #422
Conversation
Conformance comparison report
Number passing in both: 5649 Number failing in both: 694 Number passing in Base (d93dfe7) but now fail: 0 Number failing in Base (d93dfe7) but now pass: 0 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 81.70% 81.49% -0.21%
==========================================
Files 62 62
Lines 15235 15332 +97
Branches 15235 15332 +97
==========================================
+ Hits 12447 12495 +48
- Misses 2285 2334 +49
Partials 503 503
☔ View full report in Codecov by Sentry. |
_ => { | ||
let fresh_key = "_1"; // TODO don't hard-code 'fresh' keys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this TODO about not hard-coding 'fresh' keys?
39e856e
to
e70df4b
Compare
size_hint
for applicable iteratorscoerce_to_*
methods tocoerce_into_*
when they take ownershipimpl Iterator
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.