-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add errors from BaseTableExpr's to the evaluator #447
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 79.21% 79.24% +0.03%
==========================================
Files 66 66
Lines 17721 17732 +11
Branches 17721 17732 +11
==========================================
+ Hits 14037 14052 +15
+ Misses 3116 3110 -6
- Partials 568 570 +2 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (4d9ae54) but now fail: 0 Number failing in Base (4d9ae54) but now pass: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.