Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors from BaseTableExpr's to the evaluator #447

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Mar 7, 2024

  • Add errors from BaseTableExpr's to the evaluator
  • Add tests for extension errors
  • Fix cases where a runtime error could cause a permissive mode evaluator to error

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 March 7, 2024 19:08
@jpschorr jpschorr marked this pull request as ready for review March 7, 2024 19:08
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 79.24%. Comparing base (4d9ae54) to head (94fb662).
Report is 1 commits behind head on main.

Files Patch % Lines
partiql-eval/src/eval/mod.rs 80.00% 1 Missing and 1 partial ⚠️
partiql-eval/src/error.rs 0.00% 0 Missing and 1 partial ⚠️
partiql-eval/src/plan.rs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   79.21%   79.24%   +0.03%     
==========================================
  Files          66       66              
  Lines       17721    17732      +11     
  Branches    17721    17732      +11     
==========================================
+ Hits        14037    14052      +15     
+ Misses       3116     3110       -6     
- Partials      568      570       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 7, 2024

Conformance comparison report

Base (4d9ae54) 64a90cd +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (4d9ae54) but now fail: 0

Number failing in Base (4d9ae54) but now pass: 0

Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment.

partiql-eval/src/error.rs Outdated Show resolved Hide resolved
@jpschorr jpschorr requested a review from am357 March 7, 2024 20:05
@jpschorr jpschorr merged commit 6e16561 into main Mar 12, 2024
19 checks passed
@jpschorr jpschorr deleted the fix-basetableexpr-errors branch March 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants