Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat embedded doc value #514

Draft
wants to merge 3 commits into
base: dev-ion-doc
Choose a base branch
from
Draft

Conversation

jpschorr
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 63 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (75ffa06) to head (ea4cd80).

Files with missing lines Patch % Lines
partiql-ast/src/pretty.rs 3.70% 26 Missing ⚠️
partiql-value/src/embedded_doc.rs 27.58% 21 Missing ⚠️
extension/partiql-extension-ion/src/lib.rs 0.00% 7 Missing ⚠️
partiql-common/src/embedded_document.rs 66.66% 4 Missing ⚠️
partiql-logical-planner/src/lower.rs 80.00% 1 Missing and 1 partial ⚠️
extension/partiql-extension-ion/src/encode.rs 0.00% 1 Missing ⚠️
...sion/partiql-extension-visualize/src/ast_to_dot.rs 0.00% 1 Missing ⚠️
partiql-value/src/pretty.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           dev-ion-doc     #514      +/-   ##
===============================================
- Coverage        80.70%   80.27%   -0.44%     
===============================================
  Files               88       90       +2     
  Lines            19409    19496      +87     
  Branches         19409    19496      +87     
===============================================
- Hits             15665    15651      -14     
- Misses            3324     3410      +86     
- Partials           420      435      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 22, 2024

Conformance comparison report

Base (75ffa06) 1fa2589 +/-
% Passing 86.98% 84.71% -2.27%
✅ Passing 5564 5446 -118
❌ Failing 833 983 150
🔶 Ignored 0 0 0
Total Tests 6397 6429 32

Number passing in both: 5375

Number failing in both: 789

Number passing in Base (75ffa06) but now fail: 10

Number failing in Base (75ffa06) but now pass: 10

⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • partiql_tests::fail::static_analysis::primitives::primitives::functions::lower::invalid_function_args::lower::lower_wrong_type_of_arguments_param
  • partiql_tests::eval::query::select::select::select::select_distinct::permissive_selectdistinctexpression
  • partiql_tests::fail::static_analysis::primitives::primitives::functions::upper::invalid_function_args::upper::upper_wrong_type_of_arguments_param
  • partiql_tests::fail::static_analysis::primitives::primitives::functions::char_length::invalid_function_args::char_length::char_length_wrong_types_in_
  • partiql_tests::eval::query::select::select::select::select_distinct::strict_selectdistinctexpression
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_a_1_result_true
  • partiql_tests::fail::static_analysis::primitives::primitives::functions::char_length::invalid_function_args::char_length::character_length_wrong_types_in_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_a_null_result_true
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_a_null_result_true
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_a_1_result_true
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:
Click here to see
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_1_result_true_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_null_result_true_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_result_false_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_missing_result_true_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_null_result_true_
  • partiql_tests::fail::static_analysis::primitives::primitives::operator::is_operator::is_not_operator_expects_type_name
  • partiql_tests::eval::primitives::functions::functions::exists::exists::permissive_exists_valid_cases_param_1_result_true_
  • partiql_tests::eval::primitives::functions::functions::exists::exists::strict_exists_valid_cases_param_result_false_
  • partiql_tests::fail::static_analysis::primitives::primitives::operator::is_operator::is_operator_expects_type_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant