Add category for PartiqlShape
#535
Conversation
Conformance comparison report
Number passing in both: 5587 Number failing in both: 842 Number passing in Base (a409335) but now fail: 0 Number failing in Base (a409335) but now pass: 0 |
| trait TypeSatisfier { | ||
| fn satisfies(&self, value: &Value) -> bool; | ||
| } |
There was a problem hiding this comment.
nit: could add some docs for what satisfies means
| @@ -742,6 +742,12 @@ pub enum Static { | |||
| // TODO Add BitString, ByteString, Blob, Clob, and Graph types | |||
| } | |||
|
|
|||
| pub enum StaticCategory<'a> { | |||
| Tuple(), | |||
There was a problem hiding this comment.
I think we probably actually want this to represent the 'category' of tuple types. Right now, that's just Struct, but may include, e.g., Row in the future.
Similar to how it represents both Bag and List with Sequence.
jpschorr
force-pushed
the
feat-shape-category
branch
from
eafc621 to
b74749f
Compare
jpschorr
force-pushed
the
feat-bindingsname-match
branch
from
262e930 to
cd98d77
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
- Coverage 81.29% 81.27% -0.03%
==========================================
Files 90 90
Lines 19648 19672 +24
Branches 19648 19672 +24
==========================================
+ Hits 15973 15988 +15
- Misses 3255 3264 +9
Partials 420 420 ☔ View full report in Codecov by Sentry. |
jpschorr
force-pushed
the
feat-shape-category
branch
from
b74749f to
e93ee2e
Compare
jpschorr
force-pushed
the
feat-shape-category
branch
from
e93ee2e to
d9dee1f
Compare
This PR introduces
StaticCategory, a parallel toDatumCategory. This aides in type-checking againstDatum/DatumCategory.This forms part of the basis for supporting external
Variants.Cf. #529
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.