Skip to content
Code Coverage

Add boxed variant comparisons #2945

Sign in to view logs

Add boxed variant comparisons

Add boxed variant comparisons #2945

GitHub Actions / clippy failed Jan 4, 2025 in 1s

clippy

2 errors, 17 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 2
Warning 17
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check failure on line 189 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

error: this expression creates a reference which is immediately dereferenced by the compiler
   --> partiql-value/src/variant.rs:189:60
    |
189 |         l.type_tag().cmp(&r.type_tag()).then_with(|| l.cmp(&r))
    |                                                            ^^ help: change this to: `r`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[deny(clippy::needless_borrow)]` implied by `#[deny(clippy::all)]`

Check failure on line 21 in partiql-value/src/sort.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

error: the following explicit lifetimes could be elided: 'a
  --> partiql-value/src/sort.rs:21:6
   |
21 | impl<'a, const NULLS_FIRST: bool> Ord for NullSortedValue<'a, NULLS_FIRST, Value> {
   |      ^^                                                   ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
note: the lint level is defined here
  --> partiql-value/src/lib.rs:2:9
   |
2  | #![deny(clippy::all)]
   |         ^^^^^^^^^^^
   = note: `#[deny(clippy::needless_lifetimes)]` implied by `#[deny(clippy::all)]`
help: elide the lifetimes
   |
21 - impl<'a, const NULLS_FIRST: bool> Ord for NullSortedValue<'a, NULLS_FIRST, Value> {
21 + impl<const NULLS_FIRST: bool> Ord for NullSortedValue<'_, NULLS_FIRST, Value> {
   |

Check warning on line 121 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read 

warning: field `0` is never read
   --> partiql-value/src/variant.rs:121:28
    |
121 | pub struct VariantIter<'a>(BoxedVariantValueIter<'a>);
    |            -----------     ^^^^^^^^^^^^^^^^^^^^^^^^^
    |            |
    |            field in this struct
    |
    = help: consider removing this field
    = note: `#[warn(dead_code)]` on by default

Check warning on line 43 in partiql-value/src/value/iter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `doc` 

warning: unused variable: `doc`
  --> partiql-value/src/value/iter.rs:43:33
   |
43 |             ValueIter::Embedded(doc) => {
   |                                 ^^^ help: if this is intentional, prefix it with an underscore: `_doc`

Check warning on line 23 in partiql-value/src/value/iter.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `doc` 

warning: unused variable: `doc`
  --> partiql-value/src/value/iter.rs:23:33
   |
23 |             ValueIter::Embedded(doc) => {
   |                                 ^^^ help: if this is intentional, prefix it with an underscore: `_doc`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 17 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Write` 

warning: unused import: `Write`
  --> partiql-value/src/variant.rs:17:43
   |
17 | use std::fmt::{Debug, Formatter, Pointer, Write};
   |                                           ^^^^^

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read 

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read 

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read 

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read 

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read 

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read 

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read 

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read 

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 30 in partiql-value/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `Deserialize` and `Serialize` 

warning: unused imports: `Deserialize` and `Serialize`
  --> partiql-value/src/lib.rs:30:13
   |
30 | use serde::{Deserialize, Serialize};
   |             ^^^^^^^^^^^  ^^^^^^^^^

Check warning on line 17 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Pointer` 

warning: unused import: `Pointer`
  --> partiql-value/src/variant.rs:17:34
   |
17 | use std::fmt::{Debug, Formatter, Pointer, Write};
   |                                  ^^^^^^^

Check warning on line 9 in partiql-value/src/variant.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `List` 

warning: unused import: `List`
 --> partiql-value/src/variant.rs:9:13
  |
9 | use crate::{List, NullSortedValue, Value};
  |             ^^^^

Check warning on line 3 in partiql-value/src/sort.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `std::borrow::Cow` 

warning: unused import: `std::borrow::Cow`
 --> partiql-value/src/sort.rs:3:5
  |
3 | use std::borrow::Cow;
  |     ^^^^^^^^^^^^^^^^

Check warning on line 1 in partiql-value/src/sort.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `DatumCategory` and `DatumLower` 

warning: unused imports: `DatumCategory` and `DatumLower`
 --> partiql-value/src/sort.rs:1:20
  |
1 | use crate::datum::{DatumCategory, DatumLower};
  |                    ^^^^^^^^^^^^^  ^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default
View more details on GitHub Actions