Skip to content

Add boxed variant comparisons

Sign in for the full log view
GitHub Actions / clippy succeeded Jan 4, 2025 in 1s

clippy

49 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 49
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 23 in partiql-conformance-tests/src/bin/generate_comparison_report.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
  --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5
   |
23 | /// regressed behavior)
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
23 | ///   regressed behavior)
   |     ++

Check warning on line 348 in partiql-logical-planner/src/typer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unreachable pattern

warning: unreachable pattern
   --> partiql-logical-planner/src/typer.rs:348:21
    |
348 |                     _ => {
    |                     ^ no value can reach this
    |
note: multiple earlier patterns match some of the same values
   --> partiql-logical-planner/src/typer.rs:348:21
    |
336 |                     Lit::Null | Lit::Missing => type_undefined!(),
    |                     ------------------------ matches some of the same values
337 |                     Lit::Int8(_) | Lit::Int16(_) | Lit::Int32(_) | Lit::Int64(_) => {
    |                     ------------------------------------------------------------ matches some of the same values
...
340 |                     Lit::Decimal(_) => type_decimal!(),
    |                     --------------- matches some of the same values
341 |                     Lit::Double(_) => type_float64!(),
    |                     -------------- matches some of the same values
...
348 |                     _ => {
    |                     ^ ...and 6 other patterns collectively make this unreachable
    = note: `#[warn(unreachable_patterns)]` on by default

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `Assertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 149 in partiql-eval/src/eval/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `serde`

warning: unexpected `cfg` condition value: `serde`
   --> partiql-eval/src/eval/mod.rs:149:12
    |
149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    |            ^^^^^^^^^^^^^^^^^ help: remove the condition
    |
    = note: no expected values for `feature`
    = help: consider adding `serde` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default

Check warning on line 15 in partiql-conformance-tests/build.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

spawned process is never `wait()`ed on

warning: spawned process is never `wait()`ed on
  --> partiql-conformance-tests/build.rs:11:5
   |
11 | /     Command::new("cargo")
12 | |         .arg("fmt")
13 | |         .arg("--")
14 | |         .spawn()
15 | |         .expect("cargo fmt of tests/ failed");
   | |                                             ^- help: try: `.wait()`
   | |_____________________________________________|
   |
   |
   = note: not doing so might leave behind zombie processes
   = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
   = note: `#[warn(clippy::zombie_processes)]` on by default

Check warning on line 11 in extension/partiql-extension-ion/src/util.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variant `Bag` is never constructed

warning: variant `Bag` is never constructed
  --> extension/partiql-extension-ion/src/util.rs:11:5
   |
8  | pub enum PartiqlValueTarget<T> {
   |          ------------------ variant in this enum
...
11 |     Bag(Vec<T>),
   |     ^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 450 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`

warning: type `boxed_ion::BoxedIonStreamType` is more private than the item `boxed_ion::BoxedIon::parse`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:450:5
    |
450 |     pub fn parse(data: Vec<u8>, expected: BoxedIonStreamType) -> IonResult<Self> {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::parse` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonStreamType` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:522:1
    |
522 | enum BoxedIonStreamType {
    | ^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 435 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new_value`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5
    |
435 |     pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1
    |
97  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^

Check warning on line 435 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`

warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new_value`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:435:5
    |
435 |     pub fn new_value(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Value {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new_value` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1
    |
529 | enum BoxedIonValue {
    | ^^^^^^^^^^^^^^^^^^

Check warning on line 429 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::BoxedIon::new`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5
    |
429 |     pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1
    |
97  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^

Check warning on line 429 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`

warning: type `boxed_ion::BoxedIonValue` is more private than the item `boxed_ion::BoxedIon::new`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:429:5
    |
429 |     pub fn new(doc: impl Into<BoxedIonValue>, ctx: IonContextPtr) -> Self {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ associated function `boxed_ion::BoxedIon::new` is reachable at visibility `pub`
    |
note: but type `boxed_ion::BoxedIonValue` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:529:1
    |
529 | enum BoxedIonValue {
    | ^^^^^^^^^^^^^^^^^^
    = note: `#[warn(private_bounds)]` on by default

Check warning on line 113 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`

warning: type `boxed_ion::IonContext` is more private than the item `boxed_ion::IonContextPtr`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:113:1
    |
113 | pub type IonContextPtr = Rc<RefCell<IonContext>>;
    | ^^^^^^^^^^^^^^^^^^^^^^ type alias `boxed_ion::IonContextPtr` is reachable at visibility `pub`
    |
note: but type `boxed_ion::IonContext` is only usable at visibility `pub(self)`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:97:1
    |
97  | struct IonContext {
    | ^^^^^^^^^^^^^^^^^
    = note: `#[warn(private_interfaces)]` on by default

Check warning on line 406 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `e`

warning: unused variable: `e`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:406:21
    |
406 |                 Err(e) => todo!(),
    |                     ^ help: if this is intentional, prefix it with an underscore: `_e`

Check warning on line 392 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `seq`

warning: unused variable: `seq`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:392:37
    |
392 |             BoxedIonValue::Sequence(seq) => {
    |                                     ^^^ help: if this is intentional, prefix it with an underscore: `_seq`

Check warning on line 381 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `k`

warning: unused variable: `k`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:381:23
    |
381 |     fn take_val(self, k: &BindingsName<'_>) -> Option<Value> {
    |                       ^ help: if this is intentional, prefix it with an underscore: `_k`

Check warning on line 374 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `e`

warning: unused variable: `e`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:374:21
    |
374 |                 Err(e) => todo!(),
    |                     ^ help: if this is intentional, prefix it with an underscore: `_e`

Check warning on line 360 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `seq`

warning: unused variable: `seq`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:360:37
    |
360 |             BoxedIonValue::Sequence(seq) => {
    |                                     ^^^ help: if this is intentional, prefix it with an underscore: `_seq`

Check warning on line 346 in extension/partiql-extension-ion/src/boxed_ion.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `e`

warning: unused variable: `e`
   --> extension/partiql-extension-ion/src/boxed_ion.rs:346:21
    |
346 |                 Err(e) => todo!(),
    |                     ^ help: if this is intentional, prefix it with an underscore: `_e`