(PC-33625)[API] fix: Don’t create offerer address every time we patch… #16055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a121e35): https://pc-pro-testing--pr16055-dramelet-pc-33625-do-lnoenlhv.web.app (expires Fri, 31 Jan 2025 19:48:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
5 times, most recently
from
a4d6fc4 to
b01946f
Compare
dramelet-pass
had a problem deploying
to
pullrequest
GitHub Actions
Error
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
from
b01946f to
ab402e5
Compare
dramelet-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
from
ab402e5 to
ae1b5e6
Compare
| @@ -37,10 +37,17 @@ def fullAddress(self) -> str: | |||
| return f"{self.street} {self.postalCode} {self.city}" if self.street else f"{self.postalCode} {self.city}" | |||
|
|
|||
| def field_exists_and_has_changed(self, field: str, value: typing.Any) -> typing.Any: | |||
| if field in ("latitude", "longitude"): | |||
| # Rounding to five digits to keep consistency with the columns definitions | |||
| # We don’t want to consider coordinates has changed is actually the rounded value is the same | |||
There was a problem hiding this comment.
Suggested change
| # We don’t want to consider coordinates has changed is actually the rounded value is the same | |
| # We don’t want to consider coordinates has changed if the rounded value is the same |
Mini typo =)
lmaubert-pass
approved these changes
Jan 29, 2025
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
from
ae1b5e6 to
5cbd6a5
Compare
dramelet-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
xordoquy-pass
approved these changes
Jan 29, 2025
jclery-pass
had a problem deploying
to
pullrequest
GitHub Actions
Failure
abouabdallaoui-pass
approved these changes
Feb 6, 2025
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
2 times, most recently
from
9015702 to
81230c4
Compare
dramelet-pass
force-pushed
the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
from
81230c4 to
ac46f61
Compare
dramelet-pass
deleted the
dramelet/PC-33625-dont-create-oa-when-location-dont-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the venue
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-33625
Vérifications