Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding alarm that monitors %xx errors in IAM #3060

Merged
merged 3 commits into from
Nov 15, 2024
Merged

feat: adding alarm that monitors %xx errors in IAM #3060

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb1c989
feat: adding alarm that monitors %xx errors in IAM
nutrina Nov 15, 2024
4e592f4
fix: alarm config for IAM
nutrina Nov 15, 2024
babcb01
fix: naming of variable
nutrina Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions infra/aws/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as aws from "@pulumi/aws";
import * as op from "@1password/op-js";
import * as cloudflare from "@pulumi/cloudflare";
import { secretsManager, amplify } from "infra-libs";
import {stack, defaultTags} from "../lib/tags";
import { stack, defaultTags } from "../lib/tags";

const current = aws.getCallerIdentity({});
const regionData = aws.getRegion({});
Expand Down Expand Up @@ -31,6 +31,7 @@ const redisConnectionUrl = pulumi.interpolate`${coreInfraStack.getOutput("static
const albDnsName = coreInfraStack.getOutput("coreAlbDns");
const albZoneId = coreInfraStack.getOutput("coreAlbZoneId");
const albHttpsListenerArn = coreInfraStack.getOutput("coreAlbHttpsListenerArn");
const coreAlbArn = coreInfraStack.getOutput("coreAlbArn");

const passportDataScienceStack = new pulumi.StackReference(`passportxyz/passport-data/${stack}`);
const passportDataScienceEndpoint = passportDataScienceStack.getOutput("internalAlbBaseUrl");
Expand All @@ -40,8 +41,6 @@ const snsAlertsTopicArn = coreInfraStack.getOutput("snsAlertsTopicArn");
const passportXyzDomainName = coreInfraStack.getOutput("passportXyzDomainName");
const passportXyzHostedZoneId = coreInfraStack.getOutput("passportXyzHostedZoneId");



const containerInsightsStatus = stack == "production" ? "enabled" : "disabled";

// Manage secrets & envs for Passport XYZ
Expand Down Expand Up @@ -309,6 +308,35 @@ const albPassportXyzTargetGroup = new aws.lb.TargetGroup(`passport-xyz-iam`, {
},
});

/*
* Alarm for monitoring target 5XX errors
*/
const coreAlbArnSuffix = coreAlbArn.apply((arn) => arn.split(":").pop());
const http5xxTargetAlarm = new aws.cloudwatch.MetricAlarm(`HTTP-Target-5XX-passport-xyz-iam`, {
tags: { ...defaultTags, Name: `HTTP-Target-5XX-passport-xyz-iam` },
name: `HTTP-Target-5XX-passport-xyz-iam`,
alarmActions: [snsAlertsTopicArn],
okActions: [snsAlertsTopicArn],

period: 60,
statistic: "Sum",

datapointsToAlarm: 3,
evaluationPeriods: 5,

metricName: "HTTPCode_Target_5XX_Count",
namespace: "AWS/ApplicationELB",

dimensions: {
LoadBalancer: coreAlbArnSuffix,
TargetGroup: albPassportXyzTargetGroup.arnSuffix,
},

comparisonOperator: "GreaterThanThreshold",
threshold: 0,
treatMissingData: "notBreaching",
});

const albPassportXyzListenerRule = new aws.lb.ListenerRule(`passport-xyz-iam-https`, {
listenerArn: albHttpsListenerArn,
priority: 102, // This needs to be grater than the priority number for passport-scroll-badge-service
Expand Down Expand Up @@ -660,7 +688,7 @@ const ecsAutoScalingTargetXyz = new aws.appautoscaling.Target("autoscaling_targe
tags: {
...defaultTags,
Name: "autoscaling_target_xyz",
}
},
});

const ecsAutoScalingPolicyXyz = new aws.appautoscaling.Policy("passport-autoscaling-policy-xyz", {
Expand Down Expand Up @@ -793,7 +821,7 @@ const gitcoinEcsAutoScalingTarget = new aws.appautoscaling.Target("autoscaling_t
tags: {
...defaultTags,
Name: "autoscaling_target",
}
},
});

const gitcoinEcsAutoScalingPolicy = new aws.appautoscaling.Policy("passport-autoscaling-policy", {
Expand Down Expand Up @@ -852,7 +880,8 @@ const amplifyAppInfo = coreInfraStack.getOutput("newPassportDomain").apply((doma
branchName: passportBranches[stack],
environmentVariables: passportXyzAppEnvironment,
tags: { ...defaultTags, Name: `${prefix}.${domainName}` },
buildCommand: "npm install --g [email protected] && lerna bootstrap && rm -rf ../node_modules/@tendermint && npm run build",
buildCommand:
"npm install --g [email protected] && lerna bootstrap && rm -rf ../node_modules/@tendermint && npm run build",
preBuildCommand: "nvm use 20.9.0",
artifactsBaseDirectory: "out",
customRules: [
Expand Down
Loading