runningFold method alongside tests #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passsy
reviewed
Oct 5, 2022
| /// Returns a list containing the results of applying the given [operation] | ||
| /// function to each element in the original collection and the previous | ||
| /// accumulator value. | ||
| KtCollection<R> runningFold<R>(R initial, R Function(R, T) operation) { |
passsy
reviewed
Oct 5, 2022
| /// Returns a list containing the results of applying the given [operation] | ||
| /// function to each element in the original collection and the previous | ||
| /// accumulator value. | ||
| KtCollection<R> runningFold<R>(R initial, R Function(R, T) operation) { |
There was a problem hiding this comment.
Create extension for KtIterable, not KtCollection
passsy
reviewed
Oct 5, 2022
| @@ -205,6 +205,18 @@ void testCollection(KtCollection<T> Function<T>() emptyCollection, | |||
| }); | |||
| }); | |||
|
|
|||
| group("runningFold", () { | |||
There was a problem hiding this comment.
Don't forget the runningFoldIndexed variant 😉
passsy
reviewed
Oct 5, 2022
| @@ -205,6 +205,18 @@ void testCollection(KtCollection<T> Function<T>() emptyCollection, | |||
| }); | |||
| }); | |||
|
|
|||
| group("runningFold", () { | |||
| test("running folds a string list", () { | |||
| final strings = listOf<String>("a", "b", "c", "d"); | |||
There was a problem hiding this comment.
Add a test where the list is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added the runningFold method as requested in #151. Should the method stay in KtCollectionExtension?
The performed test is the same as the example present in Kotlin's documentation.
Reference: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.sequences/running-fold.html