Skip to content

feat(opeanpi): Generate openapi scema dynamically on app startup. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samip5
Copy link

@samip5 samip5 commented Jul 4, 2023

No description provided.

@samip5 samip5 changed the title feat(opeanpi): Generate openapi sceme dynamically on app startup. feat(opeanpi): Generate openapi scema dynamically on app startup. Jul 4, 2023
@romeq
Copy link
Member

romeq commented Jul 4, 2023

This version doesn't seem to compile on Docker, as there is no java installed, so I can not merge this as-is (the master branch cannot have anything that would crash an existing backend on automatic update).

I modified the Dockerfile to install openjdk17 from Alpine Linux's repositories and it seemed to work fine. However I'm not certainly sure whether we should install java on the primary docker file; it increases the size of the production image a lot.

In other words, as much as I respect your will to contribute to this project I'm not going to merge this PR as long as the functionality is not separated from the actual API-server.

Could the generator script be instead manually ran on development machines?

@samip5
Copy link
Author

samip5 commented Jul 4, 2023

Could the generator script be instead manually ran on development machines?

No, as the whole purpose of it is to dynamically use environment variables to match the deployment which shouldn't/cannot be done anywhere else easily than runtime meaning that doing it in Docker's build stage is also not something that would satisfy that need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants