Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 7.1 #94

Merged
merged 10 commits into from
Oct 23, 2023
Merged

Rails 7.1 #94

merged 10 commits into from
Oct 23, 2023

Commits on Oct 16, 2023

  1. Add Rails 7.1 to appraisals

    @patbenatar
    patbenatar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    505cbcb View commit details
    Browse the repository at this point in the history

  2. Allow gem to be installed on Rails 7.1 bundles

    @patbenatar
    patbenatar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ce3274f View commit details
    Browse the repository at this point in the history

  3. Fix backtrace cleaning for Rails 7.1 because ActionView::Template::Er… 

    …ror now explicitly delegates backtrace to cause
    @patbenatar
    patbenatar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    311d4ad View commit details
    Browse the repository at this point in the history

  4. Add Rails 7.1 to Github Actions

    @patbenatar
    patbenatar committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    2e46715 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Bump rspec versions

    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    4b00dd4 View commit details
    Browse the repository at this point in the history

  2. Make command more explicit in README

    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b0f2696 View commit details
    Browse the repository at this point in the history

  3. Rails 7.1 now requires the template to be an UnboundTemplate instance… 

    …, so we return that with backwards compat for Rails 6.1
    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    b14c0d1 View commit details
    Browse the repository at this point in the history

  4. Don't bind locals on the cached unbound templates

    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    179745f View commit details
    Browse the repository at this point in the history

  5. Upgrade dummy app to Rails 7.1 and add a regression test for children… 

    … rendering bug in 7.1
    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    5b37403 View commit details
    Browse the repository at this point in the history

  6. Fix empty children rendering bug in Rails 7.1. Because our children e… 

    …xplicitly concat on @output_buffer, we should not return anything from capture block. This used to work anyway on Rails <7.1 but it no longer works
    @patbenatar
    patbenatar committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ce59e0c View commit details
    Browse the repository at this point in the history