Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import error #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix import error #64

wants to merge 1 commit into from

Conversation

jmlinx
Copy link

@jmlinx jmlinx commented Jan 11, 2024

Importing sklearn resolves the _impl import error on M2 MacBook.

@patrick-kidger
Copy link
Owner

Signatory shouldn't depend on sklearn at all. I'm not sure where you're getting this from?

@jmlinx
Copy link
Author

jmlinx commented Jan 11, 2024

I used to have an Intel MacBook and signatory v1.2.6.1.9.0 with Python 3.8/3.9 worked well. After I switched to an M2 MacBook, with the same version of signatory and Python, I encountered an import error at line from . import _impl when I tried to import signatory. By chance I once imported sklearn before signatory and everything worked through. It seems to implicitly resolve some dependency issues. Of course, there should be a better way to address this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants