browser.css.defineEnvVar proposal #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ find . -name *_private* | xargs git rm
$ find . -name *_private* | xargs git rm
update pr-preview config to point to correct location of the specification
Update .pr-preview.json
Publish minutes of 2024-02-15 meeting
Publish minutes of 2024-02-29 meeting
* Add proposal processes Add a new proposal process for API changes. This includes a doc describing the process and a template from which proposals may be made. * Update the proposal process with feedback from Rob and Timothy. --------- Co-authored-by: Devlin Cronin <[email protected]>
Add a new README file for the proposals subdirectory detailing the contents of the directory and linking to the new proposal process.
Add proposals/README.md
Update window.browser spec status
Add interface definitions for Chromium
* Update labeler.yml Replace the general "needs-triage" label with browser-specific versions of the needs-triage label. * Update .github/labeler.yml * Update .github/labeler.yml * Update .github/labeler.yml * Update .github/labeler.yml Co-authored-by: Rob Wu <[email protected]> --------- Co-authored-by: Rob Wu <[email protected]>
* Add permissions.requestSiteAccess() API proposal * Update existing workaround to be more browser inclusive * Update proposal based on comment threads - Update Background section to take into account different browser's behavior - Update Other Alternatives Considered section to explain in better detailed why Chrome is not supportive of declarative urls * Add url option parameter and return value Proposal has been updated so it can fit every browsers model by adding a url option parameter, with this requirements: - In Chrome, we can require tab ID or document ID, but not `url`. - In Safari, they can require `url`, but not `tabId` or `documentId`. - If both are provided, they'll both be respected. It also adds a method to remove the request and specifies when the methods resolve * Change title * Address comments after 02/29 WECG meeting - Change name to `permissions.addSiteAccessRequest()` - Fix API comments * Small typos in proposal * Add inactive tab behavior * Apply suggestions from code review Co-authored-by: Rob Wu <[email protected]> * Update 'Other alternatives considered' with url pattern usage --------- Co-authored-by: EmiliaPaz <[email protected]> Co-authored-by: Rob Wu <[email protected]>
* Add userScripts.execute() API proposal * Apply suggestions from code review Addressed @Rob--W comments: - Add errors property to InjectionResult - Nits Co-authored-by: Rob Wu <[email protected]> * Minor typos: add commas and remove backticks on browser --------- Co-authored-by: EmiliaPaz <[email protected]> Co-authored-by: Rob Wu <[email protected]>
We were using ## as the top level heading but this does not match the expectation of bikeshed.
Fix heading levels in specification.
…llowed Indicate some implementors allow JSON comments in manifest.json
As we discussed at the in-person WECG meet-up, we should add expectations around review practices. This PR adds documentation for those practices.
Publish minutes of 2024-03-14 meeting
The behavior of certain APIs may not be immediately clear from the API schema. Add a separate section for "behavior" to allow authors to specify notes related to the behavior of the API if they are non- obvious.
…avior_section Expand the API proposal to include a "behavior" section
Update Simeon's affiliation
…posals_link Add references to proposing API changes in CONTRIBUTING.md
Publish minutes of 2024-03-28 meeting
Add guidance on the review expectations of proposals
Expand the proposal process to indicate that developer feedback is desirable and a core part of the proposal process. Merge managers should ensure developer feedback is carefully considered before merging proposals.
…_conduct_in_proposal_process Add reference to Code of Conduct in proposal_process.md
Adds the ARTIFACT_NAME input value to avoid an issue where conflicting artifacts were added and the workflow would fail.
Add ARTIFACT_NAME to w3c/spec-prod invocation
…-diego Publish minutes of 2024-03-18 - 2024-03-20 meetings in San Diego
Publish minutes of 2024-04-11 meeting
…e_about_developer_feedback Provide guidance on developer feedback in the proposal process
Publish minutes of 2024-04-25 meeting
* Proposal: Multiple user script worlds This adds a new API proposal for supporting multiple user script worlds, allowing user script managers to better isolate individual user scripts when multiple may be injected on a given site. This proposal follows the new API proposal process. * Address Rob's and Timothy's feedback * Update diff styling * Collapse code sections since diffing makes it clear * Expand API for better world management Expand the proposal to include: - Two new functions, `removeWorld()` and `getWorldConfigurations()`. - Notes about how the worlds behave when injecting. - Notes on world persistence and world limits. * Address Rob's latest comments * Address more review comments * Fix trailing parenthesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.