Skip to content

Commit

Permalink
minor updates to README
Browse files Browse the repository at this point in the history
So I don't forget what I was doing between now and next time I get to
work on this...
  • Loading branch information
activeshadow committed Jul 1, 2024
1 parent 0883822 commit 1bdb3ba
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 3 deletions.
21 changes: 20 additions & 1 deletion src/go/sunspec/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@ How do we want to specify point scalings?
* map scaling values to SF values?
* have deault scaling values for SF's that can be overwritten?

## Server

* If XML config element for SunSpec point is a string:
* if schema for point says it's type string:
* static value for point
* if schema for point says it's type other than string:
* OT-sim tag to get value from
* If XML config element for SunSpec point is a number:
* if schema for point says it's type string:
* ERROR
* if schema for point says it's type other than string:
* static value for point

XML config element values will always be strings. Should we try to parse as
number, catch error, and assume string on error, or should we use an XML element
attribute to denote static values? I vote first option... less typing in config.

## TODO

* [ ] Build out initial Model 1 (static data)
* [x] Build out initial Model 1 (static data)
* [ ] Add OT-sim msg bus status and update handlers
* [ ] Figure out how to handle scaling config
2 changes: 1 addition & 1 deletion src/go/sunspec/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import (
"fmt"
"strconv"

"github.com/beevik/etree"
otsim "github.com/patsec/ot-sim"
"github.com/patsec/ot-sim/sunspec/common"

"actshad.dev/modbus"
"github.com/beevik/etree"
)

type Factory struct{}
Expand Down
2 changes: 1 addition & 1 deletion src/go/sunspec/server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import (
"strconv"
"strings"

"actshad.dev/mbserver"
otsim "github.com/patsec/ot-sim"
"github.com/patsec/ot-sim/sunspec/common"

"actshad.dev/mbserver"
"github.com/beevik/etree"
)

Expand Down

0 comments on commit 1bdb3ba

Please sign in to comment.