-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: updated eslint devDepencencies #1306
base: dev
Are you sure you want to change the base?
refactor: updated eslint devDepencencies #1306
Conversation
get upstream
get upstream
missed to replace mustache initially and incorrect handlebars two times (both in package name and URL)
This reverts commit 271dc8d.
that are mentioned by the github pipeline as well
@@ -36,30 +36,6 @@ const server = (patternlab) => { | |||
patternlab.config.paths.public.root | |||
) | |||
); | |||
defaults.assets = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is an old PR which is still WIP, but could you elaborate why this gets removed when the PR only is about ESLint changes?
@@ -27,7 +27,6 @@ function serve() { | |||
return patternlab.server | |||
.serve({ | |||
cleanPublic: config.cleanPublic, | |||
watch: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for the removal of this line
Summary of changes:
It's important that someone else with ESLint, babel and webpack knowledge would have a look at these changes, especially my three code comments and the necessary evaluations.
live-server
package to an external config fileadded
no-mixed-requires
->node/no-mixed-requires
no-process-exit
->node/no-process-exit
updated dependencies
eslint-plugin-importeslint-config-airbnb-baseWe're matching the ESLint version with the updates from this pull request and Prettier even already, as well as Node.
replaced
babel-eslint
is now@babel/eslint-parser
.", source https://www.npmjs.com/package/babel-eslint and https://babeljs.io/blog/2020/07/13/the-state-of-babel-eslintChanged
rules
ESLint@7
: https://eslint.org/docs/rules/#deprecated (seeadded
section above as well)extends
https://github.com/prettier/eslint-plugin-prettier#recommended-configuration:
and read further on the section
ESLint and babel configs
sub-packages ESLint config file with an extend to root isn't necessary, as ESLint would search for that config anyhow, but we need to reference the root
babel.config.js
in our monorepo, compare to e.g.https://babeljs.io/docs/en/config-files#root-babelconfigjson-file and https://babeljs.io/docs/en/config-files#file-relative-configuration
pending
Why do we have both a.eslintrc.js
and a.eslintrc.json
in the root?#updatingdependenciesbitbybitbybitbybitbybitbybitbybitbybit