Masthead

[jgiardino]

https://jgiardino.github.io/patternfly-atomic/?p=viewall-components-masthead
https://jgiardino.github.io/patternfly-atomic/?p=viewall-components-navigation

Updates include:

• included skip to main link
• created separate components for nav, navlink, and utilities nav
• documentation and accessibility notes for masthead
• accessibility updates for masthead

Still to do:

• write documentation for nav, navlink and utilities nav

Questions:

• Where/how should the skip to main link display? Where should it display for smaller screensizes? Is it even needed when the navigation is hidden and the bars icon displays?
• Keyboard access doesn't seem to work at all in patternlab components on Firefox.
• Why do the images not display on my github page? They display locally

[andresgalante]

@jgiardino I am sure sure I am missing the point but I don't see the point of navlink been a thing by itself, why not adding it under the nav umbrella?

Also, tabs is a nav with a modifier class, so maybe we should consider putting tabs under navigation also like bootstrap does. If this increases the scope of the story and you don't have time to do it, then I can continue with it.

[andresgalante]

I think that ulClass and the other variables referring a type selector are too general. Is this a case to use styleModifier? #51

If it is I can ask Brian to fix our implementation so we can use it.

[andresgalante]

the skip link is creating horizontal scrolling

[jgiardino]

I can't believe I missed that.

[andresgalante]

@jgiardino sorry for not been able to review this :( it's been a month!

I don't really understand navlink.hbs but I'll take a closer look during the weekend and merge it early next week.

Thanks a lot!