-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multiple guidelines to reflect new usage of labels and label groups as chips #3410
Comments
This is on hold pending completion of patternfly/patternfly#5344 which has been moved to the post-V5 backlog. In the interim we want to just merge the documentation for Chip and Chip Group so they appear on the same page. Opened #3480 to track that work. |
@edonehoo - this seems to be something that is going to happen for PF6. In the staging, chips now have more of a label styling, but I guess we'll have to see exactly how we want to communicate this change in the guidelines. Leaving it on hold for now. Also created a PF6 design guidelines label to flag that this applies to the future state of PF! |
This will move towards completion as images are updated as part of a few of these #4235 (I'll update here when that one has moved more) |
Get rid of chips guidelines, and write new guidelines for labels as chips.
Design issue here: patternfly/patternfly-design#1222
Background: We have decided to fully deprecate chips in favor of labels, which will cause the following changes:
All relevant details and mocks can be found here: https://www.sketch.com/s/d7e287f4-39e3-4c17-a302-2131d8f3ea87
The text was updated successfully, but these errors were encountered: