-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(release-highlights): Adds missing package version links. #4477
base: main
Are you sure you want to change the base?
Conversation
<Timestamp>December 2024</Timestamp> | ||
|
||
## PatternFly 6.1 | ||
|
||
### Promoted package versions | ||
- patternfly/patternfly ([changelog](https://github.com/patternfly/patternfly/releases/tag/v6.1.0)) | ||
- [@patternfly/patternfly6.1.0](https://www.npmjs.com/package/@patternfly/patternfly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be consistent about having the initial @, two lines have it and the rest don't, and maybe adding a space or hyphen between the package and the version number?
@patternfly/[email protected]
would follow a pattern that I've seen notated in package.json
before, but I'm not sure there's a convention for calling out a specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good callout! Totally dropped the @ as I was building the list.
I'll make updates with your suggestions, tysm!
- [patternfly/react-templates6.1.0](https://www.npmjs.com/package/@patternfly/react-templates) | ||
- [patternfly/react-tokens6.1.0](https://www.npmjs.com/package/@patternfly/react-tokens) | ||
- PatternFly extensions | ||
- [patternfly/react-component-groups](https://www.npmjs.com/package/@patternfly/react-component-groups) ([changelog](https://github.com/patternfly/react-component-groups/releases/tag/v6.1.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also call out the version numbers for the extensions as well.
component-groups, log-viewer, topology, quickstarts all released wtih 6.1.0
and chatbot released with 2.1.0
Closes #4460