Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(release-highlights): Adds missing package version links. #4477

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edonehoo
Copy link
Collaborator

Closes #4460

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 17, 2025

<Timestamp>December 2024</Timestamp>

## PatternFly 6.1

### Promoted package versions
- patternfly/patternfly ([changelog](https://github.com/patternfly/patternfly/releases/tag/v6.1.0))
- [@patternfly/patternfly6.1.0](https://www.npmjs.com/package/@patternfly/patternfly)
Copy link
Contributor

@kmcfaul kmcfaul Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be consistent about having the initial @, two lines have it and the rest don't, and maybe adding a space or hyphen between the package and the version number?

@patternfly/[email protected] would follow a pattern that I've seen notated in package.json before, but I'm not sure there's a convention for calling out a specific version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good callout! Totally dropped the @ as I was building the list.

I'll make updates with your suggestions, tysm!

- [patternfly/react-templates6.1.0](https://www.npmjs.com/package/@patternfly/react-templates)
- [patternfly/react-tokens6.1.0](https://www.npmjs.com/package/@patternfly/react-tokens)
- PatternFly extensions
- [patternfly/react-component-groups](https://www.npmjs.com/package/@patternfly/react-component-groups) ([changelog](https://github.com/patternfly/react-component-groups/releases/tag/v6.1.0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also call out the version numbers for the extensions as well.

component-groups, log-viewer, topology, quickstarts all released wtih 6.1.0 and chatbot released with 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Add list of package versions to release highlights
4 participants