-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(toggle-group): Adds example documentation. #10309
Conversation
Preview: https://patternfly-react-pr-10309.surge.sh A11y report: https://patternfly-react-pr-10309-a11y.surge.sh |
@thatblindgeye @tlabaj have some toggle group docs for your review! Couple things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this content! I (hopefully) answered your questions/comments from above with my below comments 😆
packages/react-core/src/components/ToggleGroup/examples/ToggleGroup.md
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/ToggleGroup/examples/ToggleGroup.md
Outdated
Show resolved
Hide resolved
|
||
To do this, pass a descriptive label to the `text` property of a `<ToggleGroupItem>`. | ||
|
||
When passing both `text` and `icon` properties to a `<ToggleGroupItem>`, you can also pass in `iconPosition` to determine whether the icon is rendered at the start or end of the item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the update that added this prop was in the v6 branch, this line should be removed for this PR, but we would want to add it to the v6 branch whenever this update gets pulled into v6 (or we could open a separate PR that adds this content to v6).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that makes sense. Do you think I can just link that additional PR to the same issue, or is a new issue needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we've done either way, but a new issue wouldn't hurt. For what it's worth Michael had split out an issue assigned to me in Core into 2 separate issues, one for V5 and one for V6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #10295