Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): uncontrolled Tabs react to updated defaultActiveKey #10317

Merged
merged 2 commits into from
May 8, 2024

Conversation

adamviktora
Copy link
Contributor

What: Closes #9966

@adamviktora adamviktora requested review from a team, nicolethoen and tlabaj and removed request for a team April 30, 2024 08:31
@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 30, 2024

@adamviktora adamviktora marked this pull request as draft April 30, 2024 11:21
@adamviktora adamviktora marked this pull request as ready for review April 30, 2024 12:39
Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it using the codebox in the linked issue. It looks like it's working great!

@tlabaj tlabaj merged commit 8e21814 into patternfly:main May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Tabs - uncontrolled Tabs do not react to updated defaultActiveKey
7 participants