fix(TextMessage): Allow for more complex list output #295
+23
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Composer AI, we were seeing bad list rendering when lists contained complex formatting. React-markdown seems to categorize the complex formatting as p tags. Since they all had an inline-block on them, this caused rendering issues when the p tag was in an li. This should fix it. I also brought in a silly, more complex example based on Composer AI.
|
This is a little silly @edonehoo - let me know if you want a more real-life example here. I just need the bold and code formatting in the list. |
edonehoo
requested changes
Nov 5, 2024
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
…istant/examples/ChatbotMessage/BotMessage.tsx Co-authored-by: Erin Donehoo <[email protected]>
…istant/examples/ChatbotMessage/BotMessage.tsx Co-authored-by: Erin Donehoo <[email protected]>
|
Should be all set @edonehoo! Thank you. |
nicolethoen
approved these changes
Nov 7, 2024
|
🎉 This PR is included in version 2.1.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Composer AI, we were seeing bad list rendering when lists contained complex formatting. React-markdown seems to categorize the complex formatting as p tags. Since they all had an inline-block on them, this caused rendering issues when the p tag was in an li. This should fix it. I also brought in a silly, more complex example based on Composer AI.