Prevent repeating entries in _neighbors and explain how units and peers are encoded #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vectors referred to in the title are _group, _group_of and _neighbors.
akumm2k
changed the title
akumm2k
changed the title
This commit makes the comments clearer.
Box and square were interchanged. Box is actually the entire unit and not the square.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I landed on this repo via Peter Norvig's webpage. Some of the terminology used on his page is different than in your implementation. The comments make it easier to understand the contents of the vectors that store the units of a box -
_group- and the positions of the units in that vector for a given box -_group_of._neighborscontextually refers topeers.Moreover,
_neighborscontained unnecessary repeating entries in the implementation. Now,_neighborsresembles the set of peers.