Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Compose Multiplatform FTW #206

Merged
merged 11 commits into from
Mar 25, 2024
Merged

🚀 Compose Multiplatform FTW #206

merged 11 commits into from
Mar 25, 2024

Conversation

enthuan
Copy link
Collaborator

@enthuan enthuan commented Mar 22, 2024

Moved all the Android views to Compose Multiplatform.

Capture d’écran 2024-03-22 à 16 23 29 Capture d’écran 2024-03-22 à 16 23 56

I also cleaned the iOS codebase to remove all the obsolete code.

What's next :

  • Login Button is temporary removed. I still need to test Firebase authentication on iOS.
  • Animations have to be improved
  • OpenFeedback view is temporary removed. I saw there is a PR on the androidsdk repository to support Compose MP. If this can't be merged soon, I will use the Android view on Android and a link to the openfeedback on iOS.

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The best kinds of PRs! 👏

@martinbonnin
Copy link
Contributor

I saw there is a PR on the androidsdk repository to support Compose MP.

I'll work with @GerardPaligot to get that through the finish line

@GerardPaligot
Copy link

@martinbonnin Main issues about openfeedback kmp support is to handle resources and the ViewModel but with the latest version of Compose Multiplatform (1.6.+) and androidx ViewModel now compatible with KMP, I think we can finish my contribution about KMP on openfeedback repository!

@enthuan enthuan merged commit 1252cde into paug:main Mar 25, 2024
1 check passed
@enthuan enthuan deleted the feat/200 branch March 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants