Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openfeedback for 2024 #244

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update openfeedback for 2024 #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8caf765
Use new openfeedback ID
martinbonnin Apr 5, 2024
723ca8d
update openfeedback
martinbonnin Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ lifecycle-runtime-ktx = "androidx.lifecycle:lifecycle-runtime-ktx:2.7.0"
lifecycle-viewmodel-compose = "androidx.lifecycle:lifecycle-viewmodel-compose:2.7.0"
material = "com.google.android.material:material:1.11.0"
navigation-compose = "androidx.navigation:navigation-compose:2.7.7"
openfeedback = "io.openfeedback:openfeedback:0.2.1"
openfeedback-m3 = "io.openfeedback:openfeedback-m3:0.2.1"
openfeedback-m3 = "io.openfeedback:openfeedback-m3:0.2.2"
Comment on lines -70 to +69
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a bug when opening a session that had no votes at all, the UI would keep waiting forever

play-services-auth = "com.google.android.gms:play-services-auth:20.7.0"
moko-resources = { module = "dev.icerock.moko:resources", version.ref = "moko" }
moko-compose = { module = "dev.icerock.moko:resources-compose", version.ref = "moko" }
Expand Down
2 changes: 0 additions & 2 deletions shared/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ kotlin {
export(project(":shared:di"))
export(libs.moko.resources)
export(libs.moko.graphics)
export(libs.openfeedback)
}
}

Expand All @@ -32,7 +31,6 @@ kotlin {
api(project(":shared:ui"))
api(project(":shared:domain"))
api(project(":shared:di"))
api(libs.openfeedback)
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion shared/ui/src/commonMain/kotlin/com/androidmakers/ui/agenda/SessionDetailLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ private fun SessionDetails(
config = OpenFeedbackFirebaseConfig.default(
context = LocalPlatformContext.current
),
projectId = "am2023",
projectId = "v6kx3QuQkDU4fX0Ta989",
sessionId = sessionDetails.session.id,
)
} else {
Expand Down
Loading