Add Google signin to the Android App #255
Conversation
| @@ -72,9 +67,12 @@ class MainActivity : AppCompatActivity() { | |||
| } | |||
|
|
|||
| MainLayout( | |||
| user = userState.value, | |||
There was a problem hiding this comment.
Reason I removed it here is that it doesn't play well with Precompose (see here)
| mapScalar("LocalDateTime", "kotlinx.datetime.LocalDateTime", "com.apollographql.apollo3.adapter.KotlinxLocalDateTimeAdapter") | ||
| mapScalar("GraphQLLocalDateTime", "kotlinx.datetime.LocalDateTime", "com.apollographql.apollo3.adapter.KotlinxLocalDateTimeAdapter") |
There was a problem hiding this comment.
Forgot to make that change when changing the endpoint to androidmakers.fr/graphql
| override val user = MutableStateFlow<User?>(null) | ||
|
|
||
| init { | ||
| GlobalScope.launch { |
| class UserData: KoinComponent { | ||
| val userRepository: UserRepository by inject() | ||
| } |
There was a problem hiding this comment.
I'm not mega proud about this... The underlying problem is I didn't find a way to pass a viewModel all the way down to onActivityResult (which is not @composable). Ideas welcome.
| @@ -110,7 +109,7 @@ class MainViewModel( | |||
| val googleSignInClient = GoogleSignIn.getClient( | |||
| applicationContext, | |||
| GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN) | |||
| .requestIdToken(applicationContext.getString(R.string.default_web_client_id)) | |||
There was a problem hiding this comment.
I didn't really understand where this string came from - for me it was red in the IDE but still compiled fine ¯_(ツ)_/¯
There was a problem hiding this comment.
Same. I was thinking it was the "google-services" Gradle plugin but I don't see it applied anywhere. I'm not sure how this is generated. Maybe AGP?
There was a problem hiding this comment.
ahhh yes it's applied here actually
There was a problem hiding this comment.
Nice find 🕵️♀️!
There was a problem hiding this comment.
I'll probably remove it in a follow up PR 😄
No description provided.