Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call firebase getIdToken() #264

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Always call firebase getIdToken() #264

merged 2 commits into from
Apr 15, 2024

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Apr 15, 2024 •
edited
Loading

Do not cache the idToken in RAM. Calling getIdToken instead gives a chance to Firebase auth to refresh the token if needed

BoD
BoD approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 48f949c into main Apr 15, 2024
1 check passed
@martinbonnin martinbonnin deleted the refresh-token branch April 15, 2024 12:12
This was referenced Apr 16, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @BoD