-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road to KMP 🚀 #21
Road to KMP 🚀 #21
Conversation
Blocker to use KMM-ViewModel rickclephas/KMP-ObservableViewModel#29 |
dbbdf3d
to
570f8ad
Compare
@martinbonnin More I'm working on this contribution, less I'm convinced about the multiplatform implementation and the api exposed for Android and iOS projects. Since I configured iOS targets in Gradle modules with Cocoapod support, the build time increased and got Java memory heap exceptions (probably due to Cocoapod) randomly. What do you think about this and the necessity to use firebase kotlin sdk, moko resources, moko mvvm and multiplatform locale in this library which will be included in the final app? 🤔 |
"Just" increase JVM heap size?
Well, that's a good one, I'm not sure TBH. I have no experience with either moko resources, moko mvvm or multiplatform locale. I have limited experience with firebase kotlin sdk and I was finding this appealing to be able to share the firebase code (that should really be "just" network calls...) I realize there are a lot of "just" in my sentences above so if the field reality is different then yea, maybe KMP is not the good choice. It'd be interesting to understand where the limitation lies. If it's OOM then I'm fine giving the Kotlin compiler and Gradle more GBs of RAM (and maybe file a Youtrack if usage is patological). For build times, might be worth checking K2? |
bc885ec
to
6930a45
Compare
There are probably more things to be tweaked but I've seen this working both on Android and iOS, I'll merge the mega-PR as-is and do follow up PRs for the remaining stuff |
Done:
openfeedback
module migrated (resources and Firebase dependencies)openfeedback-viewmodel
module migrated (use moko-mvvm and multiplatform locale)openfeedback-m3
module migrated (use compose multiplatform, moko-resources-compose and moko-mvvm-compose)Todo:
openfeedback-kotlin-sdk