Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates outdated dependecies #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source :rubygems
source 'https://rubygems.org'

gemspec

Expand Down
26 changes: 15 additions & 11 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,28 @@ PATH
addressable

GEM
remote: http://rubygems.org/
remote: https://rubygems.org/
specs:
addressable (2.3.3)
archive-tar-minitar (0.5.2)
columnize (0.3.4)
diff-lcs (1.1.3)
diff-lcs (1.2.5)
linecache (0.46)
rbx-require-relative (> 0.0.4)
linecache19 (0.5.12)
ruby_core_source (>= 0.1.4)
rbx-require-relative (0.0.5)
rspec (2.7.0)
rspec-core (~> 2.7.0)
rspec-expectations (~> 2.7.0)
rspec-mocks (~> 2.7.0)
rspec-core (2.7.1)
rspec-expectations (2.7.0)
diff-lcs (~> 1.1.2)
rspec-mocks (2.7.0)
rspec (2.99.0)
rspec-core (~> 2.99.0)
rspec-expectations (~> 2.99.0)
rspec-mocks (~> 2.99.0)
rspec-core (2.99.1)
rspec-expectations (2.99.2)
diff-lcs (>= 1.1.3, < 2.0)
rspec-its (1.0.1)
rspec-core (>= 2.99.0.beta1)
rspec-expectations (>= 2.99.0.beta1)
rspec-mocks (2.99.2)
ruby-debug (0.10.4)
columnize (>= 0.1)
ruby-debug-base (~> 0.10.4.0)
Expand All @@ -45,6 +48,7 @@ PLATFORMS

DEPENDENCIES
domainatrix!
rspec
rspec (~> 2.0)
rspec-its (~> 1.0)
ruby-debug
ruby-debug19
3 changes: 2 additions & 1 deletion domainatrix.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ Gem::Specification.new do |s|
s.rubygems_version = %q{1.3.5}
s.summary = %q{A cruel mistress that uses the public suffix domain list to dominate URLs by canonicalizing, finding the public suffix, and breaking them into their domain parts.}
s.add_dependency("addressable")
s.add_development_dependency("rspec")
s.add_development_dependency("rspec", "~> 2.0")
s.add_development_dependency("rspec-its", "~> 1.0")

if s.respond_to? :specification_version then
current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
Expand Down
48 changes: 24 additions & 24 deletions spec/domainatrix/domain_parser_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,65 +7,65 @@

describe "reading the dat file" do
it "creates a tree of the domain names" do
@domain_parser.public_suffixes.should be_a Hash
expect(@domain_parser.public_suffixes).to be_a Hash
end

it "creates the first level of the tree" do
@domain_parser.public_suffixes.should have_key("com")
expect(@domain_parser.public_suffixes).to have_key("com")
end

it "creates the first level of the tree even when the first doesn't appear on a line by itself" do
@domain_parser.public_suffixes.should have_key("uk")
expect(@domain_parser.public_suffixes).to have_key("uk")
end

it "creates lower levels of the tree" do
@domain_parser.public_suffixes["jp"].should have_key("ac")
@domain_parser.public_suffixes["jp"]["kawasaki"].should have_key("*")
expect(@domain_parser.public_suffixes["jp"]).to have_key("ac")
expect(@domain_parser.public_suffixes["jp"]["kawasaki"]).to have_key("*")
end
end

describe "parsing" do
it "returns a hash of parts" do
@domain_parser.parse("http://pauldix.net").should be_a Hash
expect(@domain_parser.parse("http://pauldix.net")).to be_a Hash
end

it "includes the original url" do
@domain_parser.parse("http://www.pauldix.net")[:url].should == "http://www.pauldix.net"
expect(@domain_parser.parse("http://www.pauldix.net")[:url]).to eq("http://www.pauldix.net")
end

it "includes the scheme" do
@domain_parser.parse("http://www.pauldix.net")[:scheme].should == "http"
expect(@domain_parser.parse("http://www.pauldix.net")[:scheme]).to eq("http")
end

it "includes the full host" do
@domain_parser.parse("http://www.pauldix.net")[:host].should == "www.pauldix.net"
expect(@domain_parser.parse("http://www.pauldix.net")[:host]).to eq("www.pauldix.net")
end

it "parses out the path" do
@domain_parser.parse("http://pauldix.net/foo.html?asdf=foo")[:path].should == "/foo.html?asdf=foo"
@domain_parser.parse("http://pauldix.net?asdf=foo")[:path].should == "?asdf=foo"
@domain_parser.parse("http://pauldix.net")[:path].should == ""
expect(@domain_parser.parse("http://pauldix.net/foo.html?asdf=foo")[:path]).to eq("/foo.html?asdf=foo")
expect(@domain_parser.parse("http://pauldix.net?asdf=foo")[:path]).to eq("?asdf=foo")
expect(@domain_parser.parse("http://pauldix.net")[:path]).to eq("")
end

it "parses the tld" do
@domain_parser.parse("http://pauldix.net")[:public_suffix].should == "net"
@domain_parser.parse("http://pauldix.co.uk")[:public_suffix].should == "co.uk"
@domain_parser.parse("http://pauldix.com.kg")[:public_suffix].should == "com.kg"
@domain_parser.parse("http://pauldix.com.kawasaki.jp")[:public_suffix].should == "com.kawasaki.jp"
expect(@domain_parser.parse("http://pauldix.net")[:public_suffix]).to eq("net")
expect(@domain_parser.parse("http://pauldix.co.uk")[:public_suffix]).to eq("co.uk")
expect(@domain_parser.parse("http://pauldix.com.kg")[:public_suffix]).to eq("com.kg")
expect(@domain_parser.parse("http://pauldix.com.kawasaki.jp")[:public_suffix]).to eq("com.kawasaki.jp")
end

it "should have the domain" do
@domain_parser.parse("http://pauldix.net")[:domain].should == "pauldix"
@domain_parser.parse("http://foo.pauldix.net")[:domain].should == "pauldix"
@domain_parser.parse("http://pauldix.co.uk")[:domain].should == "pauldix"
@domain_parser.parse("http://foo.pauldix.co.uk")[:domain].should == "pauldix"
@domain_parser.parse("http://pauldix.com.kg")[:domain].should == "pauldix"
@domain_parser.parse("http://pauldix.com.kawasaki.jp")[:domain].should == "pauldix"
expect(@domain_parser.parse("http://pauldix.net")[:domain]).to eq("pauldix")
expect(@domain_parser.parse("http://foo.pauldix.net")[:domain]).to eq("pauldix")
expect(@domain_parser.parse("http://pauldix.co.uk")[:domain]).to eq("pauldix")
expect(@domain_parser.parse("http://foo.pauldix.co.uk")[:domain]).to eq("pauldix")
expect(@domain_parser.parse("http://pauldix.com.kg")[:domain]).to eq("pauldix")
expect(@domain_parser.parse("http://pauldix.com.kawasaki.jp")[:domain]).to eq("pauldix")
end

it "should have subdomains" do
@domain_parser.parse("http://foo.pauldix.net")[:subdomain].should == "foo"
@domain_parser.parse("http://bar.foo.pauldix.co.uk")[:subdomain].should == "bar.foo"
expect(@domain_parser.parse("http://foo.pauldix.net")[:subdomain]).to eq("foo")
expect(@domain_parser.parse("http://bar.foo.pauldix.co.uk")[:subdomain]).to eq("bar.foo")
end
end
end
40 changes: 20 additions & 20 deletions spec/domainatrix/url_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,53 +2,53 @@

describe "url" do
it "has the original url" do
Domainatrix::Url.new(:url => "http://pauldix.net").url.should == "http://pauldix.net"
expect(Domainatrix::Url.new(:url => "http://pauldix.net").url).to eq("http://pauldix.net")
end

it "has the public_suffix" do
Domainatrix::Url.new(:public_suffix => "net").public_suffix.should == "net"
expect(Domainatrix::Url.new(:public_suffix => "net").public_suffix).to eq("net")
end

it "has the domain" do
Domainatrix::Url.new(:domain => "pauldix").domain.should == "pauldix"
expect(Domainatrix::Url.new(:domain => "pauldix").domain).to eq("pauldix")
end

it "has the subdomain" do
Domainatrix::Url.new(:subdomain => "foo").subdomain.should == "foo"
expect(Domainatrix::Url.new(:subdomain => "foo").subdomain).to eq("foo")
end

it "has the path" do
Domainatrix::Url.new(:path => "/asdf.html").path.should == "/asdf.html"
expect(Domainatrix::Url.new(:path => "/asdf.html").path).to eq("/asdf.html")
end

it "canonicalizes the url" do
Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").canonical.should == "net.pauldix"
Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net").canonical.should == "net.pauldix.foo"
Domainatrix::Url.new(:subdomain => "foo.bar", :domain => "pauldix", :public_suffix => "net").canonical.should == "net.pauldix.bar.foo"
Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "co.uk").canonical.should == "uk.co.pauldix"
Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "co.uk").canonical.should == "uk.co.pauldix.foo"
Domainatrix::Url.new(:subdomain => "foo.bar", :domain => "pauldix", :public_suffix => "co.uk").canonical.should == "uk.co.pauldix.bar.foo"
Domainatrix::Url.new(:subdomain => "", :domain => "pauldix", :public_suffix => "co.uk").canonical.should == "uk.co.pauldix"
expect(Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").canonical).to eq("net.pauldix")
expect(Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net").canonical).to eq("net.pauldix.foo")
expect(Domainatrix::Url.new(:subdomain => "foo.bar", :domain => "pauldix", :public_suffix => "net").canonical).to eq("net.pauldix.bar.foo")
expect(Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "co.uk").canonical).to eq("uk.co.pauldix")
expect(Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "co.uk").canonical).to eq("uk.co.pauldix.foo")
expect(Domainatrix::Url.new(:subdomain => "foo.bar", :domain => "pauldix", :public_suffix => "co.uk").canonical).to eq("uk.co.pauldix.bar.foo")
expect(Domainatrix::Url.new(:subdomain => "", :domain => "pauldix", :public_suffix => "co.uk").canonical).to eq("uk.co.pauldix")
end

it "canonicalizes the url with the path" do
Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net", :path => "/hello").canonical.should == "net.pauldix.foo/hello"
expect(Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net", :path => "/hello").canonical).to eq("net.pauldix.foo/hello")
end

it "canonicalizes the url without the path" do
Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net").canonical(:include_path => false).should == "net.pauldix.foo"
expect(Domainatrix::Url.new(:subdomain => "foo", :domain => "pauldix", :public_suffix => "net").canonical(:include_path => false)).to eq("net.pauldix.foo")
end

it "combines the domain with the public_suffix" do
Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").domain_with_public_suffix.should == "pauldix.net"
Domainatrix::Url.new(:domain => "foo", :public_suffix => "co.uk" ).domain_with_public_suffix.should == "foo.co.uk"
Domainatrix::Url.new(:subdomain => "baz", :domain => "bar", :public_suffix => "com").domain_with_public_suffix.should == "bar.com"
expect(Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").domain_with_public_suffix).to eq("pauldix.net")
expect(Domainatrix::Url.new(:domain => "foo", :public_suffix => "co.uk" ).domain_with_public_suffix).to eq("foo.co.uk")
expect(Domainatrix::Url.new(:subdomain => "baz", :domain => "bar", :public_suffix => "com").domain_with_public_suffix).to eq("bar.com")
end

it "combines the domain with the public_suffix as an alias" do
Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").domain_with_tld.should == "pauldix.net"
Domainatrix::Url.new(:domain => "foo", :public_suffix => "co.uk" ).domain_with_tld.should == "foo.co.uk"
Domainatrix::Url.new(:subdomain => "baz", :domain => "bar", :public_suffix => "com").domain_with_tld.should == "bar.com"
expect(Domainatrix::Url.new(:domain => "pauldix", :public_suffix => "net").domain_with_tld).to eq("pauldix.net")
expect(Domainatrix::Url.new(:domain => "foo", :public_suffix => "co.uk" ).domain_with_tld).to eq("foo.co.uk")
expect(Domainatrix::Url.new(:subdomain => "baz", :domain => "bar", :public_suffix => "com").domain_with_tld).to eq("bar.com")
end

end
14 changes: 7 additions & 7 deletions spec/domainatrix_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@

describe "domainatrix" do
it "should parse into a url object" do
Domainatrix.parse("http://pauldix.net").should be_a Domainatrix::Url
expect(Domainatrix.parse("http://pauldix.net")).to be_a Domainatrix::Url
end

it "should canonicalize" do
Domainatrix.parse("http://pauldix.net").canonical.should == "net.pauldix"
Domainatrix.parse("http://pauldix.net/foo.html").canonical.should == "net.pauldix/foo.html"
Domainatrix.parse("http://pauldix.net/foo.html?asdf=bar").canonical.should == "net.pauldix/foo.html?asdf=bar"
Domainatrix.parse("http://foo.pauldix.net").canonical.should == "net.pauldix.foo"
Domainatrix.parse("http://foo.bar.pauldix.net").canonical.should == "net.pauldix.bar.foo"
Domainatrix.parse("http://pauldix.co.uk").canonical.should == "uk.co.pauldix"
expect(Domainatrix.parse("http://pauldix.net").canonical).to eq("net.pauldix")
expect(Domainatrix.parse("http://pauldix.net/foo.html").canonical).to eq("net.pauldix/foo.html")
expect(Domainatrix.parse("http://pauldix.net/foo.html?asdf=bar").canonical).to eq("net.pauldix/foo.html?asdf=bar")
expect(Domainatrix.parse("http://foo.pauldix.net").canonical).to eq("net.pauldix.foo")
expect(Domainatrix.parse("http://foo.bar.pauldix.net").canonical).to eq("net.pauldix.bar.foo")
expect(Domainatrix.parse("http://pauldix.co.uk").canonical).to eq("uk.co.pauldix")
end

context 'localhost with a port' do
Expand Down
1 change: 1 addition & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require "rubygems"
require "rspec"
require "rspec/its"

# gem install redgreen for colored test output
begin require "redgreen" unless ENV['TM_CURRENT_LINE']; rescue LoadError; end
Expand Down