Creating clearer KeyError messages. #18
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick first pass at trying to make the
KeyError
message clear this is a user error, and not a library error. @paulromano, Is this a reasonable approach before I go further down this path?Things implemented:
@property
wrappers for_private
fields.dict
. This overwrites__getitem__
to rewrite theKeyError
.__setitem__
for the wrapper to make it immutable. Not sure if I did this right._private
dicts to add a layer of immutability as well.TODO
Fixes #17