Compatible with cyfunction #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlov99
requested changes
Oct 30, 2021
| # This change helps to work with some modules like `pydantic`, which wraps | ||
| # functions (includes coroutine functions) into cyfunctions. The method | ||
| # `inspect.isfunction()` cannot recognize them for now. | ||
| def is_func_or_cyfunc(object): |
There was a problem hiding this comment.
@FrostyLeaf could you please add the description underneath the function as pydoc suggests?
| # Compatible with coroutine cyfunction or other kind of functions which return coroutines | ||
| # but are not coroutine functions | ||
| co_or_ret = method(*request.args, **request.kwargs) | ||
| # Maybe `inspect.isawaitable()` is better? |
There was a problem hiding this comment.
could you please elaborate on this comment? What are pros/cons of inspect.isawaitable? If we pick it, do we need this comment?
| # functions (includes coroutine functions) into cyfunctions. The method | ||
| # `inspect.isfunction()` cannot recognize them for now. | ||
| def is_func_or_cyfunc(object): | ||
| return isfunction(object) or (type(object).__name__ == "cython_function_or_method") |
There was a problem hiding this comment.
@FrostyLeaf could you please add test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.